Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a button to the playback that toggles treble voice #907

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Added a button to the playback that toggles treble voice #907

merged 5 commits into from
Sep 26, 2024

Conversation

liampond
Copy link
Contributor

Added optional argument treble_voice to volpiano2midi that raises the playback pitch by one octave.
Added a button, btnTreble that toggles this argument.

Resolves #827

@liampond liampond self-assigned this Sep 13, 2024
@dchiller
Copy link
Collaborator

@liampond Ready to merge? If so, I can get it on staging before the meeting tomorrow.

@liampond
Copy link
Contributor Author

@liampond Ready to merge? If so, I can get it on staging before the meeting tomorrow.

Sure, is there anything I need to do? I think it should be good.

@dchiller
Copy link
Collaborator

No, looks good to me! I'm happy to do it, but the general practice in the lab has been that once a PR is approved the person who opened it gets to merge it (I think in case you decide there's anything else to add?) -- anyway, just didn't want to step on your toes if there was a reason you hadn't merged.

@dchiller dchiller merged commit bcb3800 into main Sep 26, 2024
2 checks passed
@dchiller dchiller deleted the issue827_OctaveSelection branch September 26, 2024 19:30
@liampond
Copy link
Contributor Author

No, looks good to me! I'm happy to do it, but the general practice in the lab has been that once a PR is approved the person who opened it gets to merge it (I think in case you decide there's anything else to add?) -- anyway, just didn't want to step on your toes if there was a reason you hadn't merged.

I see, makes sense. Thanks Dylan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchiller dchiller dchiller approved these changes

Assignees

@liampond liampond

Labels
Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give users choice for octave of chant MIDI playback
2 participants
@liampond @dchiller